modified class_checker.py file

Author: pavan-msys

pylint/checkers/classes/class_checker.py

@@ -1535,15 +1535,14 @@ def _check_invalid_overridden_method(
             )
             return
 
-        # If both return types are not None, compare them to check for compatibility
-        if inferred_return.name != inferred_parent_return.name:
-            # The return types are incompatible, so add an error message
+        # Both have types but they differ - invalid
+        if inferred_return and inferred_parent_return and inferred_return.name != inferred_parent_return.name:
             self.add_message(
                 "invalid-overridden-method",
                 args=(
                     function_node.name,
-                    inferred_parent_return,  # Parent return type
-                    inferred_return          # Current return type
+                    inferred_parent_return,
+                    inferred_return
                 ),
                 node=function_node,
             )

tests/functional/r/invalid_overridden_method.txt

@@ -1,6 +1,6 @@
 ************* Module functional.r.invalid_overridden_method
-invalid_overridden_method.py:17:4: W0236: Method 'method' was expected to be <ClassDef.int l.0 at 0x794d71667490>, found it instead as <ClassDef.str l.0 at 0x794d713ce250> (invalid-overridden-method)
-invalid_overridden_method.py:30:4: W0236: Method 'method' was expected to be <Const.NoneType l.24 at 0x794d711b7010>, found it instead as <ClassDef.int l.0 at 0x794d71667490> (invalid-overridden-method)
-invalid_overridden_method.py:44:4: W0236: Method 'read_file' was expected to be <ClassDef.TextIOWrapper l.0 at 0x794d70fa4b90>, found it instead as <ClassDef.BytesIO l.0 at 0x794d71102ad0> (invalid-overridden-method)
-invalid_overridden_method.py:70:4: W0236: Method 'get_contents' was expected to be <Const.str l.64 at 0x794d711beb90>, found it instead as <ClassDef.dict l.0 at 0x794d715b12d0> (invalid-overridden-method)
-invalid_overridden_method.py:84:4: W0236: Method 'get_value' was expected to be <ClassDef.float l.0 at 0x794d71603990>, found it instead as <ClassDef.str l.0 at 0x794d713ce250> (invalid-overridden-method)
+invalid_overridden_method.py:17:4: W0236: Method 'method' was expected to be <ClassDef.int l.0 at 0x72df35d1f350>, found it instead as <ClassDef.str l.0 at 0x72df35c8a350> (invalid-overridden-method)
+invalid_overridden_method.py:30:4: W0236: Method 'method' was expected to be <Const.NoneType l.24 at 0x72df35a7b010>, found it instead as <ClassDef.int l.0 at 0x72df35d1f350> (invalid-overridden-method)
+invalid_overridden_method.py:44:4: W0236: Method 'read_file' was expected to be <ClassDef.TextIOWrapper l.0 at 0x72df35870dd0>, found it instead as <ClassDef.BytesIO l.0 at 0x72df359cadd0> (invalid-overridden-method)
+invalid_overridden_method.py:70:4: W0236: Method 'get_contents' was expected to be <Const.str l.64 at 0x72df35a82c10>, found it instead as <ClassDef.dict l.0 at 0x72df35e65110> (invalid-overridden-method)
+invalid_overridden_method.py:84:4: W0236: Method 'get_value' was expected to be <ClassDef.float l.0 at 0x72df35eb7850>, found it instead as <ClassDef.str l.0 at 0x72df35c8a350> (invalid-overridden-method)