Skip to content

Commit 5bc23fb

Browse files
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
1 parent 0daff2d commit 5bc23fb

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

pylint/checkers/classes/class_checker.py

+12-8
Original file line numberDiff line numberDiff line change
@@ -1528,22 +1528,26 @@ def _check_invalid_overridden_method(
15281528
"invalid-overridden-method",
15291529
args=(
15301530
function_node.name,
1531-
"None" if inferred_parent_return is None else inferred_parent_return,
1532-
"None" if inferred_return is None else inferred_return
1531+
(
1532+
"None"
1533+
if inferred_parent_return is None
1534+
else inferred_parent_return
1535+
),
1536+
"None" if inferred_return is None else inferred_return,
15331537
),
15341538
node=function_node,
15351539
)
15361540
return
15371541

15381542
# Both have types but they differ - invalid
1539-
if inferred_return and inferred_parent_return and inferred_return.name != inferred_parent_return.name:
1543+
if (
1544+
inferred_return
1545+
and inferred_parent_return
1546+
and inferred_return.name != inferred_parent_return.name
1547+
):
15401548
self.add_message(
15411549
"invalid-overridden-method",
1542-
args=(
1543-
function_node.name,
1544-
inferred_parent_return,
1545-
inferred_return
1546-
),
1550+
args=(function_node.name, inferred_parent_return, inferred_return),
15471551
node=function_node,
15481552
)
15491553

tests/functional/r/invalid_overridden_method.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ invalid_overridden_method.py:17:4: W0236: Method 'method' was expected to be <Cl
33
invalid_overridden_method.py:30:4: W0236: Method 'method' was expected to be <Const.NoneType l.24 at 0x72df35a7b010>, found it instead as <ClassDef.int l.0 at 0x72df35d1f350> (invalid-overridden-method)
44
invalid_overridden_method.py:44:4: W0236: Method 'read_file' was expected to be <ClassDef.TextIOWrapper l.0 at 0x72df35870dd0>, found it instead as <ClassDef.BytesIO l.0 at 0x72df359cadd0> (invalid-overridden-method)
55
invalid_overridden_method.py:70:4: W0236: Method 'get_contents' was expected to be <Const.str l.64 at 0x72df35a82c10>, found it instead as <ClassDef.dict l.0 at 0x72df35e65110> (invalid-overridden-method)
6-
invalid_overridden_method.py:84:4: W0236: Method 'get_value' was expected to be <ClassDef.float l.0 at 0x72df35eb7850>, found it instead as <ClassDef.str l.0 at 0x72df35c8a350> (invalid-overridden-method)
6+
invalid_overridden_method.py:84:4: W0236: Method 'get_value' was expected to be <ClassDef.float l.0 at 0x72df35eb7850>, found it instead as <ClassDef.str l.0 at 0x72df35c8a350> (invalid-overridden-method)

0 commit comments

Comments
 (0)