-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove binary files from repository #165
Comments
I think 2 of these wheels are already on PyPI, so we don't need to re-store we can "just" store a hash and redownload them checking the hash.
|
Thanks for the suggestion! But we are already quite relying on the GitHub infra (storing xbuildenv and the metadata), so everything will break if there is an issue in GitHub anyway... so would be fine to utilize GitHub to store the binary files.
Yeah, I think we can start with downloading them from PyPI, |
Yes, |
Yes, maybe let's discuss it in a separate issue. I don't like to put bunch of big files in the repository for testing, but I am also not sure whether putting it in a separate place is a good way to go.
Originally posted by @ryanking13 in #139 (comment)
My idea is to use a dummy repository and add the wheels to the GitHub release, and then download them at the time of running the tests using https://github.com/fatiando/pooch (which can cache the files as well). It is used by the
scikit-image
andscikit-learn
test suites to download data files (from SciPy's datasets, in the case for the latter), and I use it as well, for PyBaMM. However, it will store them in a separate place indeed, which might not be what we want.Another approach we could take to avoid storing them elsewhere is to remove them in a commit, and use the raw GitHub permalink for the files before said commit to keep accessing them and download them. This gives us the added benefit of the fact that GitHub also sets CORS headers on such URLs. However, we won't be able to update the files as easily with this method.
The text was updated successfully, but these errors were encountered: