Fix handling of continuation lines in Description metadata field #1220
Conversation
dnicolodi
force-pushed
the
fix-description-continuation
branch
2 times, most recently
from
a80bd00 to
ecf7e91
Compare
| or all(line.startswith(" |") for line in lines[1:]) | ||
| or all(line.startswith(" ") for line in lines[1:]) |
There was a problem hiding this comment.
| or all(line.startswith(" |") for line in lines[1:]) | |
| or all(line.startswith(" ") for line in lines[1:]) | |
| or all(line.startswith((" |", " ")) for line in lines[1:]) |
There was a problem hiding this comment.
This would implement a different check. The code as written tests whether all the line start with 8 spacer or all the lines start with 7 spaced and a pipe. The proposed code tests whether all the lines start with either 8 spaces or 7 spaces and a pipe. I don't think we should treat intermixed continuation style as valid. There is a test that ensures that someone else is not tempted into the same erroneous simplification.
|
Anyone? |
dnicolodi
force-pushed
the
fix-description-continuation
branch
from
ecf7e91 to
0c505c7
Compare
|
Can anyone have a look at this? It is my understanding that this solves a problem encountered by projects using old setuptools. |
I'll take a look at it in the coming days; the current Stats here: https://clickpy.clickhouse.com/dashboard/setuptools |
Fixes #1218.