Skip to content

Commit 1f1f8d8

Browse files
committed
Address review comments
1 parent 60b6772 commit 1f1f8d8

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

Diff for: ethereum/test/pyth.js

+4-5
Original file line numberDiff line numberDiff line change
@@ -1105,10 +1105,10 @@ contract("Pyth", function () {
11051105
2
11061106
);
11071107

1108-
// Strangely this test was failing without the hard coded gas limit.
1109-
// It will failing randomly on a place that it shouldn't without any message due to
1110-
// gas limit if the value is not hard-coded.
1111-
// Gas value 6.7m gas is very high and close to the ganache limit.
1108+
// This test fails without the hard coded gas limit.
1109+
// Without gas limit, it fails on a random place (in wormhole sig verification) which
1110+
// is probably because truffle cannot estimate the gas usage correctly. So the gas is
1111+
// hard-coded to a high value of 6.7m gas (close to ganache limit).
11121112
await expectRevertCustomError(
11131113
this.pythProxy.executeGovernanceInstruction(transferBackVaaWrong, {
11141114
gas: 6700000,
@@ -1388,7 +1388,6 @@ async function expectRevertCustomError(promise, reason) {
13881388
expect.fail("Expected promise to throw but it didn't");
13891389
} catch (revert) {
13901390
if (reason) {
1391-
// expect(revert.message).to.include(reason);
13921391
const reasonId = web3.utils.keccak256(reason + "()").substr(0, 10);
13931392
expect(
13941393
JSON.stringify(revert),

0 commit comments

Comments
 (0)