refactor(pyth-sdk-solana): refactor attribute iterators #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
commented
Jun 5, 2025
ali-behjati
force-pushed
the
refactor-attr-iter
branch
2 times, most recently
from
1d7f31a to
45e4aed
Compare
jayantk
approved these changes
Jun 5, 2025
There are some assumptions outside this SDK on the product attributes and the `size` field in particular that guarantee that the accesses are safe. This commit refactors it to add extra levels of safety to not rely on those assumptions.
ali-behjati
force-pushed
the
refactor-attr-iter
branch
from
45e4aed to
b68cf99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some assumptions outside this SDK on the product attributes and the
sizefield in particular that guarantee that the accesses are safe. This commit refactors it to add extra levels of safety to not rely on those assumptions.