Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle Downloader #691

Closed
1 task done
CypherpunkSamurai opened this issue Oct 7, 2021 · 9 comments · Fixed by #730
Closed
1 task done

Subtitle Downloader #691

CypherpunkSamurai opened this issue Oct 7, 2021 · 9 comments · Fixed by #730
Assignees
Labels
good first issue Good for newcomers hacktoberfest Supporting Hacktoberfest up-for-grabs

Comments

@CypherpunkSamurai
Copy link
Contributor

Subtitle Downloader -

A Python3 script that fetches youtube video subtitles and downloads them to current directory

Instructions

  • Create a new folder for your script and file/folder name should be appropriate.
  • Create a README.md in your folder for program Instructions
  • add requirements.txt if needed

Programming Language

  • Python

Happy Coding

@Hariprasad19036
Copy link
Contributor

Hey! I would like to work on this issue. Kindly assign this to me. Will finish it by tomorrow.

@CypherpunkSamurai
Copy link
Contributor Author

Hey! I would like to work on this issue. Kindly assign this to me. Will finish it by tomorrow.

I'm really sorry, I actually asked this project from @pawangeek on #636.

@CypherpunkSamurai
Copy link
Contributor Author

@Hariprasad19036 If you want i can make a subtitle downloader without youtube-dl, with plain youtube webscraping. I've made youtube downloader in other languages in past, its easy :)

So you can make one with youtube-dl module :)

Hacktoberfest is for everyone 😄

@CypherpunkSamurai
Copy link
Contributor Author

Hey @Hariprasad19036. I was wondering are you still looking for this project?

I can hand this issue over to you if you want, I have some things to learn and I won't be able to give this project it's time :)

@Hariprasad19036
Copy link
Contributor

@CypherpunkSamurai Yeah sure! Thanks for mentioning!

@CypherpunkSamurai
Copy link
Contributor Author

CypherpunkSamurai commented Oct 8, 2021

@pawangeek I would like @Hariprasad19036 to take over this project please.

I've already completed 4 PRs for HacktoberFest, one of the PR here in this repo was the last one (very thankful to @pawangeek for the opportunity).

HacktoberFest is for everyone, I alone don't want 2 PR in a single repo :)

@Hariprasad19036
Copy link
Contributor

Hey! @pawangeek, I have submitted a PR for this issue, and it says flake8 tests have failed. On checking the details, it shows me this:
image
There is no except statement in my code. Why is it running script.py and not my file for the flake8 test? Am i missing something? Please let me know so that I can drop another valid PR.

@pawangeek
Copy link
Contributor

It's due to another script, will fix it tomorrow

@CypherpunkSamurai
Copy link
Contributor Author

Hey! @pawangeek, I have submitted a PR for this issue, and it says flake8 tests have failed. On checking the details, it shows me this: image There is no except statement in my code. Why is it running script.py and not my file for the flake8 test? Am i missing something? Please let me know so that I can drop another valid PR.

  • You need to make sure that except is followed by
except Exception as e:
    print("Error Occurred:" + e)
  • You need to add new line at the end of the file.

@pawangeek pawangeek linked a pull request Oct 10, 2021 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Supporting Hacktoberfest up-for-grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants