-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 handle pwsh correctly under linux #10256
Conversation
Reviewer's Guide by SourceryThis pull request fixes an issue where the PowerShell activation script filename was incorrect under Linux. The change ensures that the correct filename ('activate.ps1') is used on non-Windows systems while maintaining the original filename ('Activate.ps1') on Windows. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Katze719 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
sys.platform
instead ofWINDOWS
for better cross-platform compatibility.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pull Request Check List
Resolves: #10253
Summary by Sourcery
Bug Fixes: