Fix git clone test on non-English locale

[kkhramova]

Pull Request Check List

• Added tests for changed code.
• Updated documentation for changed code.

---

When running tests using a non-English locale vcs.git.test_system.TestSystemGit test fails because git uses localized messages in its output.

To reproduce run:

LANG=uk_UA.UTF-8 poetry run pytest

This PR fixes the issue by ignoring any output from git commands.

[dimbleby]

IMO it doesnt make a lot of sense for SystemGit.run() (and .clone() and .checkout()) to return strings.

Suggest that it would be preferable to use subprocess.check_call() - sending stdout to devnull - instead of subprocess.check_output(), then the locale is of no interest to anyone.

[kkhramova]

I made the changes, @dimbleby.
Can you please take another look?

[dimbleby]

Suggest that it would be preferable to use subprocess.check_call() - sending stdout to devnull - instead of subprocess.check_output()

[kkhramova]

Thank you, @dimbleby
Now subprocess.check_output() is changed to subprocess.check_call()

[dimbleby]

and how about redirecting stdout? does the code as written write the output to the terminal?

[kkhramova]

stdout is now redirected to devnull.
@dimbleby thank you for your patient guidance.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.