Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form wheel name #16

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Form wheel name #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion hatch_cpp/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import logging
import os
import platform as sysplatform
import sys
import typing as t

from hatchling.builders.hooks.plugin.interface import BuildHookInterface
Expand All @@ -18,7 +20,7 @@
PLUGIN_NAME = "hatch-cpp"
_logger = logging.getLogger(__name__)

def initialize(self, version: str, _: dict[str, t.Any]) -> None:
def initialize(self, version: str, build_data: dict[str, t.Any]) -> None:
"""Initialize the plugin."""
# Log some basic information
self._logger.info("Initializing hatch-cpp plugin version %s", version)
Expand All @@ -30,6 +32,19 @@
self._logger.info("ignoring target name %s", self.target_name)
return

build_data["pure_python"] = False
machine = sysplatform.machine()
version_major = sys.version_info.major
version_minor = sys.version_info.minor
# TODO abi3
if "darwin" in sys.platform:
os_name = "macosx_11_0"
elif "linux" in sys.platform:
os_name = "linux"
else:
os_name = "win"

Check warning on line 45 in hatch_cpp/plugin.py

View check run for this annotation

Codecov / codecov/patch

hatch_cpp/plugin.py#L45 

Added line #L45 was not covered by tests
build_data["tag"] = f"cp{version_major}{version_minor}-cp{version_major}{version_minor}-{os_name}_{machine}"

# Skip if SKIP_HATCH_CPP is set
# TODO: Support CLI once https://github.com/pypa/hatch/pull/1743
if os.getenv("SKIP_HATCH_CPP"):
Expand Down
Loading