Add support for HTTP(S) proxies to clients. #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaugustin
force-pushed
the
http-proxy
branch
8 times, most recently
from
a05533f to
4a8be89
Compare
aaugustin
force-pushed
the
http-proxy
branch
7 times, most recently
from
8968d04 to
b36412b
Compare
This reduces the run time of the test suite by 40%, from 6.7s to 4.1s.
This avoids mixing TLS termination by mitmproxy and by websockets.
Specifically, not hiding the __cause__ of TimeoutError makes it visible when it happens while connecting to a proxy.
This allows keeping the connection open after reading the response to a CONNECT request.
aaugustin
force-pushed
the
http-proxy
branch
2 times, most recently
from
a315b8b to
6e72e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #364.