Skip to content

Docs EPUB: fix meta tags connected with Open Graph #134071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

m-aciek
Copy link
Contributor

@m-aciek m-aciek commented May 15, 2025

It's a follow-up to #132220 and #133720. This change should fix EPUB builds. When testing locally for #133720 I didn't have sphinxext-opengraph installed in the environment, that's why I didn't catch it earlier, I'm sorry.

Could we please backport it for supported versions and 3.12?

Before:

Zrzut ekranu 2025-05-16 o 00 59 52

After:

Zrzut ekranu 2025-05-16 o 01 01 58

📚 Documentation preview 📚: https://cpython-previews--134071.org.readthedocs.build/

@hugovk
Copy link
Member

hugovk commented May 16, 2025

Do meta tags even make sense for EPUB (and other builders)? If not, it's probably better to skip them altogether for those builders. Could save us future headaches as well.

@m-aciek m-aciek marked this pull request as draft May 16, 2025 14:02
@m-aciek
Copy link
Contributor Author

m-aciek commented May 16, 2025

Do meta tags even make sense for EPUB (and other builders)? If not, it's probably better to skip them altogether for those builders. Could save us future headaches as well.

It looks like they don't. https://chatgpt.com/share/6827445c-70f0-8004-bed3-353546e96afa

sphinx-doc/sphinxext-opengraph#137 @methane started the implementation of skipping them on the extension side.

@hugovk
Copy link
Member

hugovk commented May 16, 2025

It looks like they don't. chatgpt.com/share/6827445c-70f0-8004-bed3-353546e96afa

I'd prefer an authoritative source rather than a webpage that says "ChatGPT can make mistakes. Check important info."

@m-aciek
Copy link
Contributor Author

m-aciek commented May 16, 2025

It looks like they don't. chatgpt.com/share/6827445c-70f0-8004-bed3-353546e96afa

I'd prefer an authoritative source rather than a webpage that says "ChatGPT can make mistakes. Check important info."

I wasn't able to confirm that searching manually in a limited time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants