-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change root url to docs.python.org #220
base: main
Are you sure you want to change the base?
Conversation
@@ -30,7 +30,7 @@ hosted_on = | |||
issues_url = | |||
license_url = | |||
root_name = Python | |||
root_url = https://www.python.org/ | |||
root_url = https://www.docs.python.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the default for every user of this theme. Should we use html_theme_options
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, also the link has to be docs.python.org as for some reason it is otherwise broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also coming back to this option, what do we set the default as?
I don't see a need for a button to python.org, it is linked when necessary. |
We discussed this in the monthly docs workgroup meeting and decided to replace the We can add a link under "Project information:" to Not brought up in the meeting, but as mentioned in #220 (comment), let's make sure the link doesn't go to the default docs.python.org for all docs versions; it should go to the homepage of that version. For example, if on this page, the link should go to that page: |
Closes #217
📚 Documentation preview 📚: https://python-docs-theme-previews--220.org.readthedocs.build/