-
Notifications
You must be signed in to change notification settings - Fork 619
feat: testing the waf #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: testing the waf #2515
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
infra/ngwaf/variables.tf
Outdated
variable "NGWAF_EMAIL" { | ||
type = string | ||
description = "Email address associated with the token for the NGWAF API." | ||
default = "jacob.coffee@pyfound.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad
variable "NGWAF_SITE" { | ||
type = string | ||
description = "Site SHORT name for NGWAF" | ||
default = "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad
infra/ngwaf/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will yank this module into its own PR
infra/dns/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really need to do a tf import
against route53 config for py.org because there is a lot there and dont want to break things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove DNS handling as a concern for this right now. Terraforming DNS for python.org will be a much bigger project. I think the terraform states should only concern themselves with Fastly/NGWaf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to do any local testing since vars are missing in terraform cloud, but I did have a few notes!
infra/Makefile
Outdated
check: | ||
@tf validate | ||
|
||
.PHONY: yolo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to drop this, since we intend to use terraform cloud.
infra/dns/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove DNS handling as a concern for this right now. Terraforming DNS for python.org will be a much bigger project. I think the terraform states should only concern themselves with Fastly/NGWaf
What
Creates test service to test all of this under test.python.org