Skip to content

feat: sanitize release names upon submission #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: sanitize release names upon submission #2725

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86994c0
feat: sanitze release names upon submission
JacobCoffee May 6, 2025
565b4cc
fix: adjust regex
JacobCoffee May 6, 2025
40c448b
chore: clean copypasta from issue submission
JacobCoffee May 6, 2025
2325b52
feat: use validators instead of clean, override NameSlugModel name field
JacobCoffee May 6, 2025
07c9b36
Update downloads/validators.py
JacobCoffee May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion downloads/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from pages.models import Page

from .managers import ReleaseManager

from .validators import is_valid_python_release

DEFAULT_MARKUP_TYPE = getattr(settings, 'DEFAULT_MARKUP_TYPE', 'restructuredtext')

Expand Down Expand Up @@ -50,6 +50,7 @@ class Release(ContentManageable, NameSlugModel):
(PYTHON2, 'Python 2.x.x'),
(PYTHON1, 'Python 1.x.x'),
)
name = models.CharField(max_length=200, validators=[is_valid_python_release])
version = models.IntegerField(default=PYTHON3, choices=PYTHON_VERSION_CHOICES)
is_latest = models.BooleanField(
verbose_name='Is this the latest release?',
Expand Down
9 changes: 9 additions & 0 deletions downloads/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
"""Model valdators for the DOwnloads app."""

from django.core.exceptions import ValidationError
from django.core import validators

is_valid_python_release = validators.RegexValidator(
regex=r'^Python\s[\d.]+$',
message="Release name must be in the format 'Python X.Y.Z' (e.g., 'Python 3.14.0')"
)
Loading