Fix CQS signal. Id] 29511954 -- readability-redundant-string-init in fbcode/pytorch/tokenizers

facebook-github-bot · web-flow · commit 5695ef1f2894 · 2025-04-24T11:12:46.000-07:00
Differential Revision: D73434458 Pull Request resolved: #57
diff --git a/test/test_base64.cpp b/test/test_base64.cpp
@@ -19,7 +19,7 @@ TEST(Base64Test, TestDecodeSmoke) {
 }
 
 TEST(Base64Test, TestDecodeEmptyStringReturnsError) {
-  std::string text = "";
+  std::string text;
   auto result = base64::decode(text);
   EXPECT_FALSE(result.ok());
   EXPECT_EQ(result.error(), Error::Base64DecodeFailure);

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ TEST(Base64Test, TestDecodeSmoke) {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`TEST(Base64Test, TestDecodeEmptyStringReturnsError) {`
`22`		`- std::string text = "";`
	`22`	`+ std::string text;`
`23`	`23`	`auto result = base64::decode(text);`
`24`	`24`	`EXPECT_FALSE(result.ok());`
`25`	`25`	`EXPECT_EQ(result.error(), Error::Base64DecodeFailure);`