Skip to content

Option to optimize tokenizer without pcre2 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Option to optimize tokenizer without pcre2 #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/regex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Result<std::unique_ptr<IRegex>> create_regex(const std::string& pattern) {
return static_cast<std::unique_ptr<IRegex>>(std::move(re2));
}

#ifdef INCLUDE_REGEX_FALLBACK
if (re2->regex_->error_code() == re2::RE2::ErrorBadPerlOp) {
// RE2 doesn't support some Perl features, try PCRE2
auto pcre2 = std::make_unique<Pcre2Regex>("(" + pattern + ")");
Expand All @@ -56,6 +57,11 @@ Result<std::unique_ptr<IRegex>> create_regex(const std::string& pattern) {
std::cerr << "Error: " << (re2->regex_->error()) << std::endl;
return tokenizers::Error::LoadFailure;
}
#else
std::cerr << "RE2 failed to compile pattern: " << pattern << "\n";
std::cerr << "Error: " << (re2->regex_->error()) << std::endl;
return tokenizers::Error::LoadFailure;
#endif
}

} // namespace tokenizers
Loading