Add mx_fp8_bf16 kernel #1637
Merged
Add mx_fp8_bf16 kernel #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1637
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added a commit
that referenced
this pull request
Jan 29, 2025
stack-info: PR: #1637, branch: drisspg/stack/31
drisspg
force-pushed
the
drisspg/stack/31
branch
from
3b57cd9 to
ae51147
Compare
facebook-github-bot
added
the
CLA Signed
Merged
vkuzo
approved these changes
Jan 29, 2025
vkuzo
reviewed
Jan 29, 2025
drisspg
added a commit
that referenced
this pull request
Feb 3, 2025
stack-info: PR: #1637, branch: drisspg/stack/31
drisspg
force-pushed
the
drisspg/stack/31
branch
from
ae51147 to
1e3d2dd
Compare
drisspg
added a commit
that referenced
this pull request
Feb 3, 2025
stack-info: PR: #1637, branch: drisspg/stack/31
drisspg
force-pushed
the
drisspg/stack/31
branch
from
1e3d2dd to
8d90a66
Compare
drisspg
added a commit
that referenced
this pull request
Feb 3, 2025
stack-info: PR: #1637, branch: drisspg/stack/31
drisspg
force-pushed
the
drisspg/stack/31
branch
from
8d90a66 to
0646800
Compare
Merged
drisspg
force-pushed
the
drisspg/stack/31
branch
from
0646800 to
7473aca
Compare
drisspg
force-pushed
the
drisspg/stack/31
branch
from
7473aca to
d410880
Compare
drisspg
force-pushed
the
drisspg/stack/31
branch
2 times, most recently
from
b26ae7b to
7b9df4d
Compare
drisspg
force-pushed
the
drisspg/stack/31
branch
from
7b9df4d to
1b1e6b5
Compare
drisspg
force-pushed
the
drisspg/stack/31
branch
from
1b1e6b5 to
2febf48
Compare
drisspg
force-pushed
the
drisspg/stack/31
branch
from
2febf48 to
eb5a573
Compare
drisspg
force-pushed
the
drisspg/stack/31
branch
from
eb5a573 to
b005006
Compare
vkuzo
reviewed
Feb 12, 2025
stack-info: PR: #1637, branch: drisspg/stack/31
drisspg
force-pushed
the
drisspg/stack/31
branch
from
b005006 to
e18a020
Compare
stack-info: PR: #1661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Add mx_fp8_bf16 kernel
Will flesh out more but this moves over the kernel from here: https://github.com/drisspg/driss_torch/blob/2813322f0b0f9a0f0fc8d382090ad0aaecf3468a/src/mx_fp8_bf16.cu#L162
This does fp8xfp8 w/ E8m0 scales and group_size hard coded to 32. The format for the scales is the same as that for cublasLT. I have created a pytorch function that converts the [n_rows, n_cols//32] scales into the expected format:
https://github.com/drisspg/transformer_nuggets/blob/382cb0f19a5f615827174289b8ef552419d51fea/transformer_nuggets/mx/to_blocked.py#L11
This was surprisingly hard fought and would not have been possible w/ @albanD 😊
This allows this PR: #1625 to not have any dependencies on PT core updates while we add the required dtypes and bindings to cublas: pytorch/pytorch#145562
Follow up
Config needs more tuning