Skip to content

Get rid of fixed number cmake --build -j in sh and docs #10887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kirklandsign opened this issue May 14, 2025 · 3 comments
Open

Get rid of fixed number cmake --build -j in sh and docs #10887

kirklandsign opened this issue May 14, 2025 · 3 comments
Labels
good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@kirklandsign
Copy link
Contributor

kirklandsign commented May 14, 2025 •
edited by pytorch-bot bot
Loading

📚 The doc issue

Right now we have a few places where the number of cmake --build -j is fixed.
https://github.com/search?q=repo%3Apytorch%2Fexecutorch+%22+-j%22&type=code

Ideally let's use
mac: $(sysctl -n hw.ncpu) - 1
linux: $(nproc) - 1

Update these docs and scripts.

Suggest a potential alternative/fix

No response

cc @larryliu0820 @jathu
@kirklandsign kirklandsign added good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 14, 2025
@MichaelIspas
Copy link

I would like to be assigned this issue if possible, thank you.

@larryliu0820
Copy link
Contributor

I would like to be assigned this issue if possible, thank you.

Feel free to take it and submit PR.

@MichaelIspas
Copy link

Thank you @larryliu0820, I've created a pull request #11351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
New Contributors Projects and Issues
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MichaelIspas @larryliu0820 @kirklandsign