-
Notifications
You must be signed in to change notification settings - Fork 592
[ET-VK] Fixing out_limits_scaled calculation for conv2d pw ops. #11251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ET-VK] Fixing out_limits_scaled calculation for conv2d pw ops. #11251
Conversation
The fix changing the calculation of `out_limits_scaled` from: ```glsl const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y}; ``` to: ```glsl const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y}; ``` This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation. Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11251
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit daa207d with merge base f8a3fd8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D75575662 |
… ops." The fix changing the calculation of `out_limits_scaled` from: ```glsl const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y}; ``` to: ```glsl const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y}; ``` This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation. Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D75575662 |
… ops." The fix changing the calculation of `out_limits_scaled` from: ```glsl const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y}; ``` to: ```glsl const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y}; ``` This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation. Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D75575662 |
ddbd266
into
gh/trivedivivek/107/base
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11251 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Stack from ghstack (oldest at bottom):
The fix changing the calculation of
out_limits_scaled
from:to:
This change ensures that
out_limits_scaled
is calculated correctly, taking into account the tile size and the output limits of the convolution operation.Differential Revision: D75575662