Skip to content

[ET-VK] Fixing out_limits_scaled calculation for conv2d pw ops. #11251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented May 30, 2025

Stack from ghstack (oldest at bottom):

The fix changing the calculation of out_limits_scaled from:

const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y};

to:

const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y};

This change ensures that out_limits_scaled is calculated correctly, taking into account the tile size and the output limits of the convolution operation.

Differential Revision: D75575662

The fix changing the calculation of `out_limits_scaled` from:
```glsl
const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y};
```
to:
```glsl
const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y};
```

This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation.

Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/)

[ghstack-poisoned]
@trivedivivek trivedivivek requested a review from SS-JIA as a code owner May 30, 2025 14:56
Copy link

pytorch-bot bot commented May 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11251

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit daa207d with merge base f8a3fd8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75575662

@trivedivivek trivedivivek added the release notes: vulkan Changes to the Vulkan backend delegate label May 30, 2025
… ops."

The fix changing the calculation of `out_limits_scaled` from:
```glsl
const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y};
```
to:
```glsl
const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y};
```

This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation.

Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75575662

… ops."

The fix changing the calculation of `out_limits_scaled` from:
```glsl
const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y};
```
to:
```glsl
const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y};
```

This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation.

Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75575662

@facebook-github-bot facebook-github-bot merged commit ddbd266 into gh/trivedivivek/107/base May 30, 2025
98 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/trivedivivek/107/head branch May 30, 2025 20:15
trivedivivek added a commit that referenced this pull request May 31, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #11251 by
@trivedivivek
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/orig
@diff-train-skip-merge

---------

Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants