[ET-VK] Fixing out_limits_scaled calculation for conv2d pw ops. #11251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix changing the calculation of `out_limits_scaled` from:
```glsl
const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y};
```
to:
```glsl
const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y};
```
This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation.
Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11251
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit daa207d with merge base f8a3fd8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced May 30, 2025
Merged
|
This pull request was exported from Phabricator. Differential Revision: D75575662 |
trivedivivek
added
the
release notes: vulkan
… ops."
The fix changing the calculation of `out_limits_scaled` from:
```glsl
const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y};
```
to:
```glsl
const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y};
```
This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation.
Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/)
[ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75575662 |
… ops."
The fix changing the calculation of `out_limits_scaled` from:
```glsl
const int out_limits_scaled[2] = {out_limits.x + (TILE_SIZE_X - 1) * TILE_SIZE_X, out_limits.y + (TILE_SIZE_Y - 1) * TILE_SIZE_Y};
```
to:
```glsl
const int out_limits_scaled[2] = {(out_limits.x + (TILE_SIZE_X - 1)) / TILE_SIZE_X, (out_limits.y + (TILE_SIZE_Y - 1)) / TILE_SIZE_Y};
```
This change ensures that `out_limits_scaled` is calculated correctly, taking into account the tile size and the output limits of the convolution operation.
Differential Revision: [D75575662](https://our.internmc.facebook.com/intern/diff/D75575662/)
[ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75575662 |
SS-JIA
approved these changes
May 30, 2025
facebook-github-bot
merged commit ddbd266
into
gh/trivedivivek/107/base
98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
May 31, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11251 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/107/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The fix changing the calculation of
out_limits_scaledfrom:to:
This change ensures that
out_limits_scaledis calculated correctly, taking into account the tile size and the output limits of the convolution operation.Differential Revision: D75575662