Skip to content

[ET-VK] Adding more pointwise convolution tests. #11358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented Jun 4, 2025

Stack from ghstack (oldest at bottom):

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.

Differential Revision: D75961457

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11358

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

❌ 3 Cancelled Jobs, 1 Unrelated Failure

As of commit 5c68500 with merge base b2c02fe (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2025
trivedivivek added a commit that referenced this pull request Jun 4, 2025
This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)

ghstack-source-id: 288156669
Pull Request resolved: #11358
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75961457

Copy link

github-actions bot commented Jun 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Jun 4, 2025
Pull Request resolved: #11358

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.
ghstack-source-id: 288179770
@exported-using-ghexport

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75961457

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Jun 5, 2025
Pull Request resolved: #11358

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.
ghstack-source-id: 288417630
@exported-using-ghexport

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75961457

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Jun 5, 2025
Pull Request resolved: #11358

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.
ghstack-source-id: 288423777
@exported-using-ghexport

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75961457

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Jun 5, 2025
Pull Request resolved: #11358

This diff adds new test cases for pointwise convolution in the Vulkan backend of Executorch. The updated test cases cover different configurations of convolution layers, including kernel size, padding, stride, and groups.
ghstack-source-id: 288568638
@exported-using-ghexport

Differential Revision: [D75961457](https://our.internmc.facebook.com/intern/diff/D75961457/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75961457

@facebook-github-bot facebook-github-bot merged commit 11e4bcd into gh/trivedivivek/111/base Jun 6, 2025
93 of 98 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/trivedivivek/111/head branch June 6, 2025 03:38
trivedivivek added a commit that referenced this pull request Jun 6, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #11358 by
@trivedivivek
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/111/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/111/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/111/orig
@diff-train-skip-merge

Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants