Slightly better typing and doc comment for query clickhouse #6607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
clee2000
commented
May 8, 2025
| } | ||
|
|
||
| acc[row.pr_num].push(row.merge_commit_sha); | ||
| acc.get(row.pr_num)!.push(row.merge_commit_sha); |
There was a problem hiding this comment.
idk what happened to the typing here, it starts out as a map, but then acc is {key: string} and the return value is also a map
so im just making it always a map
clee2000
commented
May 8, 2025
| @@ -77,7 +77,7 @@ export async function fetchFlakyTestsAcrossFileReruns( | |||
| if (!workflowJobMap.has(curr.job_id)) { | |||
| return accum; | |||
| } | |||
| const job_info = workflowJobMap.get(curr.job_id); | |||
| const job_info = workflowJobMap.get(curr.job_id)!; | |||
There was a problem hiding this comment.
don't know why suddenly need ! but typechecker complains about undefined later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move doc comment so that it is compatible with vscode hover
Also add example for output
More specific typing for the output of queryclickhouse, this results in a bunch of (mostly type related changes in other places)
not sure if this is a good idea