Enable custom perf models in MemoryBalancedPartitioner #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2025 17:35
Summary: Update the critical path definition in the planner logs to match what we think is the most realistic option. See the docstring for the detailed modeling. The goal is to later feed this into the proposer and partitioner to test if we can improve upon the current greedy algorithm used with the new perf model. We will also replace a [similar version](https://www.internalfb.com/code/fbsource/[50e47c413eb3d4e00facb9df71592f9aa81d8aee]/fbcode/torchrec/distributed/planner/stats.py?lines=1071) of this function in the stats.py to avoid duplicating the logic. Differential Revision: D73207877
Summary: We are enabling custom perf models while evaluating candidate plans in `MemoryBalancedPartitioner`. This will enable us to leverage the new critical path model defined in `NoopCriticalPathPerfModel` while trying to construct a memory balanced plan with the greedy partitioner. Upcoming diffs will modify the greedy partitioner to leverage the new perf model. Differential Revision: D73292939
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73292939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We are enabling custom perf models while evaluating candidate plans in
MemoryBalancedPartitioner. This will enable us to leverage the new critical path model defined inNoopCriticalPathPerfModelwhile trying to construct a memory balanced plan with the greedy partitioner.Upcoming diffs will modify the greedy partitioner to leverage the new perf model.
Differential Revision: D73292939