Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpip: ignore network with a netmask set to None #478

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

MatthieuDartiailh
Copy link
Member

For such netmask, the mask is 32 bits long per psutil docs.

For such netmask, the mask is 32 bits long per psutil docs and
@MatthieuDartiailh
Copy link
Member Author

Closes #474

Can you test @mattjaffe42 ?

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.42%. Comparing base (d484ff9) to head (9c061b4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyvisa_py/tcpip.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   24.42%   24.42%           
=======================================
  Files          23       23           
  Lines        3492     3492           
  Branches      400      400           
=======================================
  Hits          853      853           
  Misses       2634     2634           
  Partials        5        5           
Flag Coverage Δ
unittests 24.42% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattjaffe42
Copy link

@MatthieuDartiailh tested, and confirmed resolves the error!

@MatthieuDartiailh MatthieuDartiailh merged commit 3eb0986 into main Dec 29, 2024
17 of 19 checks passed
@MatthieuDartiailh MatthieuDartiailh deleted the tcpip-list-netmask branch December 29, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants