Fix cirq-to-stim conversion not adding TICKs for multi-moment single-rep CircuitOperations
#728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strilanc
reviewed
Mar 21, 2024
|
Can you give an example of a current bad output in the description of the PR? |
On Whereas after this PR the output circuit is |
|
@Strilanc I think this should be ready to go! (although some of the CI are failing, but I don't think this is related to my change?). Please take another look when you get a chance! |
|
It was failing because you were using |
Strilanc
changed the title
TICK for multi-moment single-rep CircuitOperations
Strilanc
changed the title
TICK for multi-moment single-rep CircuitOperationsTICKs for multi-moment single-rep CircuitOperations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in
mainwhen we convert a cirq circuit to stim with aCircuitOperationwith a single repetition (or withflatten=True) no TICK instructions are inserted since the moments are removed in thecirq.decompose_once(op)command.