link tesseract with stim and add tests for the python wrapper of common.h #32
+216
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
changed the title
LalehB
approved these changes
Jun 11, 2025
| @@ -65,3 +65,11 @@ http_archive( | |||
| urls = ["https://github.com/bazelbuild/platforms/archive/refs/tags/0.0.6.zip"], | |||
| strip_prefix = "platforms-0.0.6", | |||
| ) | |||
|
|
|||
| http_archive( | |||
| name = "stim_py", | |||
There was a problem hiding this comment.
I have a general question Nour!
do you think there might be a Stim version mismatch between this line that requires Stim 15 and the one in lines 21–26 of the same WORKSPACE file?
There was a problem hiding this comment.
technically yes, but the difference between these two versions is two days ... for now this is fine since this is a workaround ... I think I should add the bazel rules in external/stim_py to stim itself to avoid having two dependencies on stim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some classes in stim are not exposed directly to python (e.g. DemTarget) instead they are exposed through a child class (e.g. ExposedDemTarget) ... this forces us to do the conversion to be able to cross the python/C++ boundary.
note that This PR doesn't actually link with stim instead the rule "@stim_py//:stim" rebuilds the python wrapper for stim in a way that allows us to use it. this is in order to unblock this project until I figure out how to link to the
stim.sofile generated by https://github.com/quantumlib/Stim/blob/f566b83c5da89ab94d7280178e2bd642350180c3/BUILD#L90TODO: find the correct way to link to the
stim.sofile.part of #17