Skip to content

SADeprecationWarning - Implement an import_dbapi() #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PRICEKRAKEN opened this issue Apr 6, 2024 · 4 comments · May be fixed by #33
Open

SADeprecationWarning - Implement an import_dbapi() #9

PRICEKRAKEN opened this issue Apr 6, 2024 · 4 comments · May be fixed by #33

Comments

@PRICEKRAKEN
Copy link

SADeprecationWarning: The dbapi() classmethod on dialect classes has been renamed to import_dbapi(). Implement an import_dbapi() classmethod directly on class <class 'questdb_connect.dialect.QuestDBDialect'> to remove this warning; the old .dbapi() classmethod may be maintained for backwards compatibility.
@PRICEKRAKEN
Copy link
Author

https://docs.sqlalchemy.org/en/20/core/internals.html#sqlalchemy.engine.default.DefaultDialect.import_dbapi

@PRICEKRAKEN
Copy link
Author

#10

@PRICEKRAKEN
Copy link
Author

PRICEKRAKEN commented Apr 6, 2024 •
edited
Loading

I see this project has requirement:

SQLAlchemy ('SQLAlchemy<=1.4.47')

After this merge it would be
SQLAlchemy ('SQLAlchemy >= 2.0')

I run the questdb-connect module already with SQLAlchemy 2.0.
Except the SADeprecationWarning i had no issues so far.

Can we work to bring this thing to SQLAlchemy 2.0 and onwards?
Or would it break to much?

@jerrinot
Copy link
Contributor

@PRICEKRAKEN I am afraid raising hard-requirment to 2.0 is a no-go. Since there are still users of 1.4. I believe the latest stable version of Apache Superset still uses 1.4 too: https://github.com/apache/superset/blob/4.1.1/requirements/base.txt#L336

@AchmadFathoni AchmadFathoni linked a pull request May 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SADeprecationWarning AchmadFathoni/questdb-connect
2 participants
@jerrinot @PRICEKRAKEN