Repeated storage error messages

[fmassot]

On storage connection error, I got the following in my terminal:

 Error Details

 ✖ storage
The specified bucket does not exist

Caused by:
    The specified bucket does not exist

The redundancy is not very nice.

[fulmicoton]

Confirmed it still happens today.

[JerryKwan]

@fulmicoton @fmassot
Would you please help to confirm if it's still happens today? thank you

[JerryKwan]

@fulmicoton @fmassot
There are more duplicate error messages such as

✘ Command failed: Failed to connect to metastore: `Internal error: Failed to get index files. Cause: `StorageError(kind=Internal, source=failed to construct request: A region must be set when sending requests to S3. (ConstructionFailure(ConstructionFailure { source: ResolveEndpointError { message: "A region must be set when sending requests to S3.", source: None } })))`.`

Caused by:
    Internal error: Failed to get index files. Cause: `StorageError(kind=Internal, source=failed to construct request: A region must be set when sending requests to S3. (ConstructionFailure(ConstructionFailure { source: ResolveEndpointError { message: "A region must be set when sending requests to S3.", source: None } })))`.

But I need help about how to trigger the duplicate message @fmassot reported

✖ storage
The specified bucket does not exist

[JerryKwan]

@fulmicoton @fmassot
In order to solve this issue, we need to refactor the error handler and considering the usage of Trait anyhow::Context

[JerryKwan]

@fmassot @fulmicoton
The root cause of the duplicate error message is the representation of error messages when using #[error("...")] to generate Display impl, such as

    #[error("failed to connect to metastore: `{0}`")]
    Initialization(#[from] MetastoreError),
    
    #[error("internal error: {message}; cause: `{cause}`")]
    Internal { message: String, cause: String },

quickwit/quickwit/quickwit-metastore/src/error.rs

Line 40 in 8c22505

#[error("failed to connect to metastore: `{0}`")]

quickwit/quickwit/quickwit-proto/src/metastore/mod.rs

Line 117 in 2de3fb9

#[error("internal error: {message}; cause: `{cause}`")]

[JerryKwan]

@fmassot @fulmicoton
Such error definition like these will output duplicate error messages like the one outlines before
https://github.com/quickwit-oss/quickwit/blob/main/quickwit/quickwit-doc-mapper/src/error.rs#L27-L38
Should we re-factor the string representation of the Errors?