Test scheduling solution stability #5793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
commented
Jun 11, 2025
| @@ -208,6 +208,27 @@ fn assert_enforce_nodes_cpu_capacity_post_condition( | |||
| ); | |||
| } | |||
|
|
|||
| // ---------------------------------------------------- | |||
There was a problem hiding this comment.
not related to the PR, just moved this up because it was wrongly placed.
Comment on lines
+214
to
+217
| // No need to fill indexer_assignments with empty assignments. | ||
| if num_shards == 0 { | ||
| return; | ||
| } |
There was a problem hiding this comment.
this doesn't change the logic, just ensures a more consistent representation of the state so that we can compare it better in tests.
rdettai
force-pushed
the
test-solution-stability
branch
from
8976249 to
5b9c955
Compare
rdettai
force-pushed
the
explicit-scheduling-rescaling
branch
from
c065f94 to
1b57434
Compare
rdettai
force-pushed
the
test-solution-stability
branch
from
5b9c955 to
b62e363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that sometime the scheduling solution changes when the same problem is solved multiple times. This PR adds a test to ensure that this happens only once and we don't end up with an unstable solution.
How was this PR tested?
This PR doesn't change the logic, only adds tests.