Fix #163

Author: wlandau-lilly

R/record_status.R

@@ -25,7 +25,7 @@
 #' @param staging Character string, file path to the JSON manifest
 #'   of package versions in the Staging universe.
 #'   Used to identify staged packages.
-#'   Set to `NULL` (default) to ignore when processing the Community unvierse.
+#'   Set to `NULL` (default) to ignore when processing the Community universe.
 #' @examples
 #' \dontrun{
 #' output <- tempfile()

man/record_status.Rd

@@ -101,3 +101,60 @@ test_that("record_status() with dependency problems", {
     expect_false(status[[package]]$success)
   }
 })
+
+test_that("record_status() with failed check on already staged package", {
+  output <- tempfile()
+  lines <- c(
+    "[",
+    " {",
+    " \"package\": \"nanonext\",",
+    " \"version_current\": \"1.0.0\",",
+    " \"hash_current\": \"hash_1.0.0-modified\",",
+    " \"version_highest\": \"1.0.0\",",
+    " \"hash_highest\": \"hash_1.0.0\"",
+    " }",
+    "]"
+  )
+  versions <- tempfile()
+  staging <- tempfile()
+  on.exit(unlink(c(output, versions, staging), recursive = TRUE))
+  writeLines(lines, versions)
+  mock <- mock_meta_packages
+  lines <- c(
+    "[",
+    " {",
+    " \"package\": \"nanonext\",",
+    " \"url\": \"https://github.com/r-lib/nanonext\",",
+    " \"branch\": \"hash_1.0.0-modified\"",
+    " }",
+    "]"
+  )
+  writeLines(lines, staging)
+  suppressMessages(
+    record_status(
+      versions = versions,
+      staging = staging,
+      mock = list(
+        packages = mock,
+        today = "2024-01-01"
+      ),
+      output = output,
+      verbose = TRUE
+    )
+  )
+  expect_true(file.exists(output))
+  status <- jsonlite::read_json(output, simplifyVector = TRUE)
+  expect_equal(
+    status$nanonext$versions,
+    list(
+      version_current = "1.0.0",
+      hash_current = "hash_1.0.0-modified",
+      version_highest = "1.0.0",
+      hash_highest = "hash_1.0.0"
+    )
+  )
+  # nanonext is already staged,
+  # so failing checks should not longer penalize reverse dependencies.
+  expect_null(status$mirai$dependencies)
+  expect_null(status$crew$dependencies)
+})