This repository was archived by the owner on Nov 18, 2020. It is now read-only.
Handle the move of the enabled_plugins file #407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoloRin
force-pushed
the
enabled_plugins_file
branch
2 times, most recently
from
e78dd26 to
f75e820
Compare
|
I believe the travis build is failing because the broker needs to be running with the code from rabbitmq/rabbitmq-server#2298 |
|
Yes, this is a fundamental limitation of Travis' "one project = one repository" philosophy. |
We look for the enabled_plugins file at the deprecated location, and at the new location. If it exists only at the deprecated location, we attempt to use that file. If the deprecated location is read-only, we allow the cli command to fail (or not) as it always used to. Part of the changes intended to address rabbitmq/rabbitmq-server#2234
HoloRin
force-pushed
the
enabled_plugins_file
branch
from
f75e820 to
206f1dc
Compare
dumbbell
reviewed
Apr 20, 2020
| {:ok, Path.join([rabbitmq_base, "enabled_plugins"])} | ||
| end | ||
| file -> | ||
| {:ok, file} |
There was a problem hiding this comment.
The duplication of the logic between rabbitmq-server and this repository makes me think more and more there is something wrong with that file, but at a deeper level. Otherwise the patches solve the immediate issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We look for the enabled_plugins file at the deprecated location, and at the new location. If it exists only at the deprecated location, we attempt to use that file. If the deprecated location is read-only, we allow the cli command to fail (or not) as it always used to.
Part of the changes intended to address rabbitmq/rabbitmq-server#2234