-
Notifications
You must be signed in to change notification settings - Fork 72
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: Centralize Platform information
1. All platform data/metadata are now stored in src/app/auth/model/auth-credentials.ts 2. This is a central source of truth from which other components, like platform-credentials-modal.component.ts can get Platform data like API endpoints, labels etc. 3. This refactor was needed because the existing hacky formula for extracting information from the API URL breaks with the China setup and 4. It is error prone to add platform information in multiple places, for example when F4C was added the short and long names were not updated. We now use DRY principle and centralize the platform list. 5. China platform added to list
- Loading branch information
Kaushik Ghose
committed
Feb 22, 2019
1 parent
1f72279
commit c1a57dd
Showing
2 changed files
with
59 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters