style: [FC-0063] Code style issues are resolved

raccoongang · Jan 10, 2025 · a6bf660 · a6bf660
1 parent a22451c
commit a6bf660
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 24 deletions.
diff --git a/src/cc2olx/olx_generators/assignment.py b/src/cc2olx/olx_generators/assignment.py
@@ -21,27 +21,20 @@ def create_nodes(self, content: dict) -> List[xml.dom.minidom.Element]:
             "openassessment",
             [
                 el("title", content["title"]),
-                el("assessments", [
-                    el(
-                        "assessment",
-                        None,
-                        {"name": "staff-assessment", "required": "True"}
-                    )
-                ]),
-                el("prompts", [
-                    el("prompt", [
-                        el("description", content["prompt"])
-                    ])
-                ]),
-                el("rubric", [
-                    *generate_default_ora_criteria(),
-                    el(
-                        "feedbackprompt",
-                        "(Optional) What aspects of this response stood out to you? What did it do well? How could it "
-                        "be improved?",
-                    ),
-                    el("feedback_default_text", "I think that this response..."),
-                ])
+                el("assessments", [el("assessment", None, {"name": "staff-assessment", "required": "True"})]),
+                el("prompts", [el("prompt", [el("description", content["prompt"])])]),
+                el(
+                    "rubric",
+                    [
+                        *generate_default_ora_criteria(),
+                        el(
+                            "feedbackprompt",
+                            "(Optional) What aspects of this response stood out to you? What did it do well? How could "
+                            "it be improved?",
+                        ),
+                        el("feedback_default_text", "I think that this response..."),
+                    ],
+                ),
             ],
             self._generate_openassessment_attributes(content),
         )

diff --git a/src/cc2olx/olx_generators/utils.py b/src/cc2olx/olx_generators/utils.py
@@ -27,7 +27,7 @@ def generate_default_ora_criteria() -> List[xml.dom.minidom.Element]:
                         el(
                             "explanation",
                             "Difficult for the reader to discern the main idea. Too brief or too repetitive to "
-                            "establish or maintain a focus."
+                            "establish or maintain a focus.",
                         ),
                     ],
                     {"points": "0"},

diff --git a/tests/test_content_parsers/test_assignment.py b/tests/test_content_parsers/test_assignment.py
@@ -13,7 +13,7 @@ class TestAssignmentContentParser:
             (True, False, "required"),
             (False, True, ""),
             (False, False, "required"),
-        ]
+        ],
     )
     def test_get_text_response_results(
         self,
@@ -34,7 +34,7 @@ def test_get_text_response_results(
             (True, False, ""),
             (False, True, "required"),
             (False, False, ""),
-        ]
+        ],
     )
     def test_get_file_upload_response_results(
         self,