-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: QTI support is improved #4
fix: QTI support is improved #4
Conversation
@@ -321,7 +334,7 @@ def parse_qti(self): | |||
root = tree.getroot() | |||
|
|||
# qti xml can contain multiple problems represented by <item/> elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we changed the code to consider all sections instead of just one with root_section
identifier. Comment doesn't relate to identifiers, so nothing changed related to the comment, we still can have multiple <item/>
elements.
476cdd3
to
13dbbc7
Compare
- failing the script with `KeyError` when Common Cartridge to process contains <assessment> with <item> that doesn't have `title` attribute is fixed - <section> with not `root_section` identifiers inside <assessment> are processed now. They were ignored before - failing the script with `KeyError` when Common Cartridge to process contains `respcondition` tags without `continue` attribute is fixed - failing the script with `AttributeError` when Common Cartridge to process contains <material> that is not a direct child of <solutionmaterial> is fixed - Fill in the blank QTIs with regexp answers support is added
bec83a8
to
60183b2
Compare
Description
During the cc2olx converter usage with correct Common Cartridge course
.imscc
dumps some problems with CC XML processing were encountered. It caused by handling of special cases by the converter while the actual CC XML can be much more complicated. This PR is intended to solve the encountered problems.Also, it's found out that cc2olx completely ignores the fact that both OeX "Text Problem" and CC "Fill in the blank" support regexps, so their support is added.
Steps to reproduce
Untitled quiz item
.imscc
dump (or use the attached oneuntitled_quiz_item_dump.imscc.zip but remove
.zip
extention leaving.imscc
): ensure you have theassessment
withitem
that doesn't havetitle
attribute.For example,
KeyError
message.Section with not
root_section
identifier.imscc
dump (or use the attached onesection_with_not_root_section_identifier.imscc.zip but remove
.zip
extention leaving.imscc
): ensure you have theassessment
withsection
whichident
attribute value isn'troot_section
.For example,
respcondition
withoutcontinue
attribute.imscc
dump (or use the attached one respcondition_without_continue_attribute.imscc.zip but remove.zip
extention leaving.imscc
): ensure you have theassessment
withrespcondition
withoutcontinue
attribute.For example,
KeyError
message.material
is not direct child ofsolutionmaterial
.imscc
dump (or use the attached one material_is_not_direct_child_of_solutionmaterial.zip but remove.zip
extention leaving.imscc
): ensure you have theassessment
withitemfeedback
,itemfeedback
hassolution
child,solution
hassolutionmaterial
,material
is not a direct child ofsolutionmaterial
:flow_mat
is asolutionmaterial
child,material
is aflow_mat
child.For example,
AttributeError
message.Fill in the blank
with regexp.imscc
dump (or use the attached one fib_with_regexp.imscc.zip but remove.zip
extention leaving.imscc
): ensure you have theFill in the blank
assessment withresprocessing
that containsrespcondition
withvarsubstring
inconditionvar
.For example,
IndexError
message.Supporting information
FC-0063
Deadline
"None"