diff --git a/core/__snapshots__/TestGenerateBuildPlanForExamples_mise-config_1.snap.json b/core/__snapshots__/TestGenerateBuildPlanForExamples_mise-config_1.snap.json index 36ebed3..e5dd09c 100755 --- a/core/__snapshots__/TestGenerateBuildPlanForExamples_mise-config_1.snap.json +++ b/core/__snapshots__/TestGenerateBuildPlanForExamples_mise-config_1.snap.json @@ -26,15 +26,6 @@ "step": "packages:mise" }, { - "include": [ - "/app/node_modules" - ], - "step": "prune" - }, - { - "exclude": [ - "node_modules" - ], "include": [ "." ], @@ -126,23 +117,15 @@ } }, { - "caches": [ - "npm-install" - ], - "commands": [ - { - "cmd": "npm prune --omit=dev" - } - ], "inputs": [ { "step": "install" } ], "name": "prune", - "variables": { - "NPM_CONFIG_PRODUCTION": "true" - } + "secrets": [ + "*" + ] }, { "caches": [ diff --git a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-bun_1.snap.json b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-bun_1.snap.json index 7cc312c..c1d9012 100755 --- a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-bun_1.snap.json +++ b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-bun_1.snap.json @@ -25,15 +25,6 @@ "step": "packages:mise" }, { - "include": [ - "/app/node_modules" - ], - "step": "prune" - }, - { - "exclude": [ - "node_modules" - ], "include": [ "." ], @@ -125,24 +116,15 @@ } }, { - "caches": [ - "bun-install" - ], - "commands": [ - { - "cmd": "sh -c 'rm -rf node_modules \u0026\u0026 bun install --production'", - "customName": "rm -rf node_modules \u0026\u0026 bun install --production" - } - ], "inputs": [ { "step": "install" } ], "name": "prune", - "variables": { - "NPM_CONFIG_PRODUCTION": "true" - } + "secrets": [ + "*" + ] }, { "caches": [ diff --git a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-corepack_1.snap.json b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-corepack_1.snap.json index 7af489d..b21c605 100755 --- a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-corepack_1.snap.json +++ b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-corepack_1.snap.json @@ -25,15 +25,6 @@ "step": "packages:mise" }, { - "include": [ - "/app/node_modules" - ], - "step": "prune" - }, - { - "exclude": [ - "node_modules" - ], "include": [ ".", "/root/.cache" @@ -137,23 +128,15 @@ } }, { - "caches": [ - "pnpm-install" - ], - "commands": [ - { - "cmd": "pnpm prune --prod" - } - ], "inputs": [ { "step": "install" } ], "name": "prune", - "variables": { - "NPM_CONFIG_PRODUCTION": "true" - } + "secrets": [ + "*" + ] }, { "caches": [ diff --git a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-next_1.snap.json b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-next_1.snap.json index 469a57b..6a4afdd 100755 --- a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-next_1.snap.json +++ b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-next_1.snap.json @@ -29,15 +29,6 @@ "step": "packages:mise" }, { - "include": [ - "/app/node_modules" - ], - "step": "prune" - }, - { - "exclude": [ - "node_modules" - ], "include": [ "." ], @@ -129,23 +120,15 @@ } }, { - "caches": [ - "npm-install" - ], - "commands": [ - { - "cmd": "npm prune --omit=dev" - } - ], "inputs": [ { "step": "install" } ], "name": "prune", - "variables": { - "NPM_CONFIG_PRODUCTION": "true" - } + "secrets": [ + "*" + ] }, { "caches": [ diff --git a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-npm-workspaces_1.snap.json b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-npm-workspaces_1.snap.json index 8f0228f..40f3316 100755 --- a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-npm-workspaces_1.snap.json +++ b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-npm-workspaces_1.snap.json @@ -25,15 +25,6 @@ "step": "packages:mise" }, { - "include": [ - "/app/node_modules" - ], - "step": "prune" - }, - { - "exclude": [ - "node_modules" - ], "include": [ "." ], @@ -133,23 +124,15 @@ } }, { - "caches": [ - "npm-install" - ], - "commands": [ - { - "cmd": "npm prune --omit=dev" - } - ], "inputs": [ { "step": "install" } ], "name": "prune", - "variables": { - "NPM_CONFIG_PRODUCTION": "true" - } + "secrets": [ + "*" + ] }, { "caches": [ diff --git a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-npm_1.snap.json b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-npm_1.snap.json index 5a1c5d5..65c54b1 100755 --- a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-npm_1.snap.json +++ b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-npm_1.snap.json @@ -25,15 +25,6 @@ "step": "packages:mise" }, { - "include": [ - "/app/node_modules" - ], - "step": "prune" - }, - { - "exclude": [ - "node_modules" - ], "include": [ "." ], @@ -125,23 +116,15 @@ } }, { - "caches": [ - "npm-install" - ], - "commands": [ - { - "cmd": "npm prune --omit=dev" - } - ], "inputs": [ { "step": "install" } ], "name": "prune", - "variables": { - "NPM_CONFIG_PRODUCTION": "true" - } + "secrets": [ + "*" + ] }, { "caches": [ diff --git a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-pnpm-workspaces_1.snap.json b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-pnpm-workspaces_1.snap.json index 544d30b..d567e09 100755 --- a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-pnpm-workspaces_1.snap.json +++ b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-pnpm-workspaces_1.snap.json @@ -25,15 +25,6 @@ "step": "packages:mise" }, { - "include": [ - "/app/node_modules" - ], - "step": "prune" - }, - { - "exclude": [ - "node_modules" - ], "include": [ "." ], @@ -137,23 +128,15 @@ } }, { - "caches": [ - "pnpm-install" - ], - "commands": [ - { - "cmd": "pnpm prune --prod" - } - ], "inputs": [ { "step": "install" } ], "name": "prune", - "variables": { - "NPM_CONFIG_PRODUCTION": "true" - } + "secrets": [ + "*" + ] }, { "caches": [ diff --git a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-turborepo_1.snap.json b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-turborepo_1.snap.json index fb51075..0c53315 100755 --- a/core/__snapshots__/TestGenerateBuildPlanForExamples_node-turborepo_1.snap.json +++ b/core/__snapshots__/TestGenerateBuildPlanForExamples_node-turborepo_1.snap.json @@ -33,15 +33,6 @@ "step": "packages:mise" }, { - "include": [ - "/app/node_modules" - ], - "step": "prune" - }, - { - "exclude": [ - "node_modules" - ], "include": [ ".", "/root/.cache" @@ -168,23 +159,15 @@ } }, { - "caches": [ - "npm-install" - ], - "commands": [ - { - "cmd": "npm prune --omit=dev" - } - ], "inputs": [ { "step": "install" } ], "name": "prune", - "variables": { - "NPM_CONFIG_PRODUCTION": "true" - } + "secrets": [ + "*" + ] }, { "caches": [ diff --git a/core/providers/node/node.go b/core/providers/node/node.go index 0348e06..ea62a1b 100644 --- a/core/providers/node/node.go +++ b/core/providers/node/node.go @@ -66,7 +66,9 @@ func (p *NodeProvider) Plan(ctx *generate.GenerateContext) error { // Prune prune := ctx.NewCommandStep("prune") prune.AddInput(plan.NewStepInput(install.Name())) - p.PruneNodeDeps(ctx, prune) + if p.shouldPrune(ctx) { + p.PruneNodeDeps(ctx, prune) + } // Build build := ctx.NewCommandStep("build") @@ -154,10 +156,6 @@ func (p *NodeProvider) shouldPrune(ctx *generate.GenerateContext) bool { } func (p *NodeProvider) PruneNodeDeps(ctx *generate.GenerateContext, prune *generate.CommandStepBuilder) { - if !p.shouldPrune(ctx) { - return - } - prune.Variables["NPM_CONFIG_PRODUCTION"] = "true" prune.Secrets = []string{} p.packageManager.PruneDeps(ctx, prune)