bun doesn't not need node by default

railwayapp · Jan 29, 2025 · d8a7c60 · d8a7c60
1 parent d65f180
commit d8a7c60
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/core/providers/node/node.go b/core/providers/node/node.go
@@ -126,16 +126,19 @@ func (p *NodeProvider) Packages(ctx *generate.GenerateContext, packageJson *Pack
 	packages := ctx.GetMiseStepBuilder()
 
 	// Node
-	node := packages.Default("node", DEFAULT_NODE_VERSION)
+	if packageManager.requiresNode(packageJson) {
+		node := packages.Default("node", DEFAULT_NODE_VERSION)
 
-	if envVersion, varName := ctx.Env.GetConfigVariable("NODE_VERSION"); envVersion != "" {
-		packages.Version(node, envVersion, varName)
-	}
+		if envVersion, varName := ctx.Env.GetConfigVariable("NODE_VERSION"); envVersion != "" {
+			packages.Version(node, envVersion, varName)
+		}
 
-	if packageJson.Engines != nil && packageJson.Engines["node"] != "" {
-		packages.Version(node, packageJson.Engines["node"], "package.json > engines > node")
+		if packageJson.Engines != nil && packageJson.Engines["node"] != "" {
+			packages.Version(node, packageJson.Engines["node"], "package.json > engines > node")
+		}
 	}
 
+	// Bun
 	if packageManager == PackageManagerBun {
 		bun := packages.Default("bun", DEFAULT_BUN_VERSION)
 

diff --git a/core/providers/node/package_manager.go b/core/providers/node/package_manager.go
@@ -171,3 +171,19 @@ func (p PackageManager) GetPackageManagerPackages(ctx *generate.GenerateContext,
 		packages.Default("yarn", "2")
 	}
 }
+
+func (p PackageManager) requiresNode(packageJson *PackageJson) bool {
+	if p != PackageManagerBun || packageJson == nil {
+		return true
+	}
+
+	scripts := packageJson.Scripts
+
+	for _, script := range scripts {
+		if strings.Contains(script, "node") {
+			return true
+		}
+	}
+
+	return false
+}