Allow users to modify monitors data #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcorbin
force-pushed
the
feature/allow-modifying-monitors-data
branch
2 times, most recently
from
40a56dd to
7639ea8
Compare
Sometimes, it's useful to modify data in the monitoring_data table, for example, in case of a false positive. I'm adding a new button in the monitor list that opens a popup allowing users to change the status of monitor data for a given time range.
mcorbin
force-pushed
the
feature/allow-modifying-monitors-data
branch
from
7639ea8 to
8785c60
Compare
|
Can you add screenshots please @mcorbin |
|
Sure. See the new button:
The form:
As I said I'm a terrible frontend dev so feel free to modify the code if needed (or to make suggestions :D) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, it's useful to modify data in the monitoring_data table, for example, in case of a false positive.
I'm adding a new button in the monitor list that opens a popup allowing users to change the status of monitor data for a given time range.
Disclaimer: I'm not a javascript/svelte developer :D