Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with more specific instructions around adding a package #1100

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Update README.md with more specific instructions around adding a package #1100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6bba62
Update README.md with more specific instructions around adding a package
adamkpickering Jan 15, 2025
c04b541
Implement Diogo and Troy's suggested changes
adamkpickering Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ In order to add a helm chart to this repository:
[`partner-charts-ci` documentation](https://github.com/rancher/partner-charts-ci).
`partner-charts-ci` can be obtained by running `scripts/pull-scripts`, which
downloads the right version for your machine to `bin/partner-charts-ci`.
3. Create a pull request for your changes targeting the `main-source` branch in this repository.
3. Create a pull request for your changes targeting the `main-source` branch in
this repository. **Please ensure that your pull request only contains changes
related to the package that you are adding.** The `PACKAGE` environment variable
is useful for this; for more information please see the
[`partner-charts-ci` documentation](https://github.com/rancher/partner-charts-ci?tab=readme-ov-file#4-run-partner-charts-ci-update).


### Who is responsible for maintaining the helm charts in this repository?
Expand Down
Loading