Ready clusters have condition[type==Ready && status=True]

rancher · Jan 13, 2025 · 45a9ba9 · 45a9ba9
1 parent 0247d1f
commit 45a9ba9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/pkg/resources/virtual/clusters/clusters.go b/pkg/resources/virtual/clusters/clusters.go
@@ -31,7 +31,7 @@ func TransformManagedCluster(obj *unstructured.Unstructured) (*unstructured.Unst
 			logrus.Errorf("Failed to process condition %v (%d) as a map", condition, i)
 			return obj, fmt.Errorf("failed to parse a condition as a map")
 		}
-		if conditionMap["type"] == "Ready" {
+		if conditionMap["type"] == "Ready" && conditionMap["status"] == "True" {
 			connectedStatus = true
 			break
 		}

diff --git a/pkg/resources/virtual/clusters/clusters_test.go b/pkg/resources/virtual/clusters/clusters_test.go
@@ -50,6 +50,13 @@ func TestTransformManagedCluster(t *testing.T) {
 								"transitioning":  false,
 								"type":           "SystemProjectCreated",
 							},
+							map[string]interface{}{
+								"error":          false,
+								"lastUpdateTime": "2025-01-10T22:52:17Z",
+								"status":         "False",
+								"transitioning":  false,
+								"type":           "Ready",
+							},
 						},
 					},
 				},
@@ -88,6 +95,13 @@ func TestTransformManagedCluster(t *testing.T) {
 								"transitioning":  false,
 								"type":           "SystemProjectCreated",
 							},
+							map[string]interface{}{
+								"error":          false,
+								"lastUpdateTime": "2025-01-10T22:52:17Z",
+								"status":         "False",
+								"transitioning":  false,
+								"type":           "Ready",
+							},
 						},
 						"connected": false,
 					},