Use fs.rm() over deprecated rmdir() for recursive cleanup

Author: haggholm

lib/tmp.js

@@ -706,6 +706,9 @@ async function withSubdir(prefix, fn, options) {
     ...(options && options.logTags ? options.logTags : {}),
     path: tmpDir
   };
+
+  // Note: we're currently only deleting the leaf (where all files will be
+  // created); the current version may leave empty directories in place.
   _logger.debug(logTags, "Create temp dir");
   await fsp.mkdir(tmpDir, { recursive: true });
 
@@ -714,7 +717,7 @@ async function withSubdir(prefix, fn, options) {
       _logger.info(logTags,"lib-tmp.gc.start");
       const t0 = Date.now();
       try {
-        await fsp.rmdir(tmpDir, { recursive: true, maxRetries: 5 });
+        await fsp.rm(tmpDir, { recursive: true, maxRetries: 5 });
         _logger.info({ ...logTags, duration: Date.now() - t0 }, "lib-tmp.gc.end");
       } catch (error) {
         _logger.info({ ...logTags, duration: Date.now() - t0, error }, "lib-tmp.gc.error");