Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options to specify custom visibility etc. columns #80

Open
o-smirnov opened this issue Oct 28, 2020 · 1 comment
Open

add options to specify custom visibility etc. columns #80

o-smirnov opened this issue Oct 28, 2020 · 1 comment
Assignees

Comments

@o-smirnov
Copy link
Collaborator

When using a custom visibility column (e.g. DIR1_DATA), the code doesn't know up front that the dims are (row, chan, corr). The data mappers, in particular, need this info. It can be supplied to the table_schema argument of xds_from_table (as table_shema=["MS", dict(...)].

Suggest adding an optional --column-dims argument. If not given, assume a shape of (chan, corr) for columns ending in _DATA, or complain for other unknown array columns.

Standard known columns are in this list: https://github.com/ska-sa/dask-ms/blob/master/daskms/table_schemas.py

@o-smirnov
Copy link
Collaborator Author

@Athanaseus was bitten by this one, so time to prioritize it up. In the meantime @Athanaseus please try the issue-80 branch which has a kludgy terrible temporary workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant