Skip to content

Commit a4c7b5c

Browse files
committed
fixed failing flow solver tests
I was not updating mem attributes in the time update while loop. This means that everytime the blending scheme sees mem, it resets the solution fields to the beginning of the assimilation window.
1 parent c7ff474 commit a4c7b5c

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

src/flow_solver/discretisation/time_update.py

+10-4
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,14 @@ def do(
161161
# Blending : Do blending before timestep
162162
######################################################
163163
swe_to_lake, Sol, mpv, t = schemes.blending_before_timestep(
164-
mem,
164+
# Sol,
165+
# flux,
166+
# mpv,
165167
bld,
168+
mem,
169+
# elem,
170+
# node,
171+
# th,
166172
ud,
167173
label,
168174
writer,
@@ -641,9 +647,9 @@ def do(
641647
time.step = step
642648
time.window_step = window_step
643649

644-
mem.sol = Sol
645-
mem.flux = flux
646-
mem.mpv = mpv
650+
mem.sol = Sol
651+
mem.flux = flux
652+
mem.mpv = mpv
647653

648654
return mem
649655
# return [Sol, flux, mpv, [window_step, step]]

src/interfaces/dynamics_blending/schemes.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -382,8 +382,14 @@ def do_hydro_to_nonhydro_conv(
382382
# Blending calls from data.py
383383
######################################################
384384
def blending_before_timestep(
385-
mem,
385+
# Sol,
386+
# flux,
387+
# mpv,
386388
bld,
389+
mem,
390+
# elem,
391+
# node,
392+
# th,
387393
ud,
388394
label,
389395
writer,

0 commit comments

Comments
 (0)