fix: memoized otp input and added example for using onOTPFilled #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tewarig
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315 and
saurabhdaware
as code owners
🦋 Changeset detectedLatest commit: 960c115 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
tewarig
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 960c115:
|
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@razorpay/blade': major | |||
it was related to this |
| @@ -419,7 +419,7 @@ const _OTPInput: React.ForwardRefRenderFunction<HTMLInputElement[], OTPInputProp | |||
| ); | |||
| }; | |||
|
|
|||
| const OTPInput = React.forwardRef<HTMLInputElement[], OTPInputProps>(_OTPInput); | |||
| const OTPInput = memo(React.forwardRef<HTMLInputElement[], OTPInputProps>(_OTPInput)); | |||
There was a problem hiding this comment.
What is the cause of re-renders though? Shouldn't it not re-render independent of whether we have memo or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with the OTPInput component where the onOTPFilled callback was causing infinite re-renders.
https://stackblitz.com/edit/react-hsrtdxhg?file=App.js
To avoid re-renders, we can wrap OTPInput in React.memo. I have implemented this. Additionally, the function passed to onOTPFilled should be wrapped in useCallback. I have added an example for this in the documentation.
Changes
Additional Information
Component Checklist