-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set messaging has bad math somewhere #61
Comments
a rather confusing collection of bugs, fixed in commit 10e4b62.
|
Man, fantastic catch there! (this is in the current help patch too, which I guess would never really manifest given how things are setup) |
oops! |
Actually yeah, or rather, that was how it functioned up to this point. I guess there could be more granular outputs when the list outlet becomes modular, but knowing the lowest and highest point in the buffer being used is handy for the purposes of [waveform~]. |
|
ultimately, in karma~ v2, we'll have modular outputs for the list, and this will include the option of outputting loop size directly, rather than having to make it in max. |
Summary:
When you use a
set
message, it appears to be either sending the wrong start/end points out the list outlet, or the pointer is wrong, or both.Steps to reproduce:
Send
record
to create a long (>2000ms) silent loop. Sendstop
to definite the initial loop. Sendset whatever 500. 1000.
to define just a subset of that loop. Now start audio playback into [karma~], sendplay
to [karma~] (so it starts playing back the silent loop), then sendrecord
to enter an overdub state.Actual results:
You see that the playhead (from the list outlet) and what is being written into the buffer phase away from each other and that what has been written into the buffer doesn't fill the entire area being shown in [waveform~] (as defined by the start/end points in the list outlet).
Expected results:
The playhead should match the visible record head, and the material that is recorded should cover the whole [waveform~] display.
Comments:
Playback itself doesn't have a silent gap in it (like [waveform~] would lead one to believe) so this must mean that the list outlet start/end points are wrong.
This may have to do with the issue I mention in #57, or be like #57 in general.
(I thought there might have been a different issue going on with jumping as well, but it appears it's actually the same problem. It may be worth double checking in the code that the boundaries defined by
set
messages clamp thejump
messages.)Example code:
The text was updated successfully, but these errors were encountered: