-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCPCH Chart - Global styles are not encapsulated to component - v7.0.12 #109
Comments
Thanks for the report and sorry for the delayed acknowledgement @dmc-cambric - we are working on this |
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
eatyourpeas
added a commit
to gdfreitas/digital-growth-charts-react-component-library
that referenced
this issue
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Team,
Got another small issue with the font import changes. When the RCPCHChart component is rendered on the screen, its font is applied to other elements in our web app outside of the RCPCH component.
I think the source of the issue is the createGlobalStyle function from styled-components, I believe that when RCPCHChart component is mounted, the font styles applied to the header and body tags are applied globally to the DOM, and thus across our app.
Could these styles be changed instead to apply to tags within a wrapper div element so there's no overlap when using the component?
createGlobalStyle func:
digital-growth-charts-react-component-library/src/RCPCHChart/RCPCHChart.tsx
Line 56 in 5c6b367
In app example:

The text was updated successfully, but these errors were encountered: