Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor props for styles #83

Closed
dc2007git opened this issue Mar 29, 2024 · 1 comment
Closed

Refactor props for styles #83

dc2007git opened this issue Mar 29, 2024 · 1 comment
Assignees
@eatyourpeas @dc2007git
Labels
discussion A discussion that has been had or needs to be had

Comments

@dc2007git
Copy link
Contributor

[discussion on pairing session] Simon and I were having a discussion about styles. We spoke about the different styles, whether they are necessary, whether we should expose them to the user for customisation, and whether we should pass in only a theme prop as opposed to individual styles.

Points made:

  • The title should not be exposed for customisation (to maintain the data label (ie UKWHO), and the chart type (ie height/length)). The SUBTITLE however, can be exposed, as the integrators may want to place patient information such as NHS number.
@dc2007git dc2007git added the discussion A discussion that has been had or needs to be had label Mar 29, 2024
@eatyourpeas
Copy link
Member

Fixed and merged in v7.0.0. Documentation updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eatyourpeas eatyourpeas

@dc2007git dc2007git

Labels
discussion A discussion that has been had or needs to be had
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eatyourpeas @dc2007git