-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Age buttons don't work independently when multiple charts are on screen #85
Comments
Interesting @dmc-cambric thanks for raising. They two charts should not influence each other's behaviour as each receive props, but do not have callbacks to their parent. I wonder if it something to do with the way the data is passed in? In the second chart you do not seem to have any datapoints rendered? Are you rendering two instances of the component, or the same one twice? Also, the data needs to be passed in in a different format:
See line 12 for our implementation in the client. If you are happy to post your code, that might help, or reach out separately by email and we can try and troubleshoot. |
Thanks for your response, the second chart is actually rendering the correct data points as intended (top left of the right-hand chart shows the only measurement added). The charts rendered above are configured for use with v7.0.0, as two separate components. The charts have the following args passed into them, which I believe conforms to the recent changes.
I'm not entirely sure the issue is the way the data is passed in, as the actual age buttons don't highlight on the right chart when clicked, which I believe is not affected by the data state? If you've got any ideas would really appreciate it, otherwise yeah I'm happy to discuss further via. email if you guys would like to see code |
That all looks right @dmc-cambric. Perhaps let's catch up on email? |
Ran into a problem whereby the age buttons do not toggle correctly on a chart when multiple charts are on screen.
Brief summary:
We have started displaying multiple growth charts on screen at the same time.
In the above example we have two chart components rendered. The left chart behaves as intended, with the current age type button highlighted, clicking between these buttons also behaves as intended when updating the chart.
However the right chart doesn't highlight any of the age buttons, and clicking them causes the age buttons (and chart points) of the left chart to toggle.
All other buttons on the chart work fine, independently from one another as does zooming, its just the age buttons that don't work for the chart on the right.
Any advice you can provide is much appreciated!
Using Ver 7.0.0
Cheers, Dan
The text was updated successfully, but these errors were encountered: