Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deemphasised lines at nondisjunctions between references #98

Closed
3 tasks done
eatyourpeas opened this issue Aug 23, 2024 · 2 comments · Fixed by #114
Closed
3 tasks done

Implement deemphasised lines at nondisjunctions between references #98

eatyourpeas opened this issue Aug 23, 2024 · 2 comments · Fixed by #114
Assignees
Labels
consistency Not strictly a bug, but an implementation could be made clearer discussion A discussion that has been had or needs to be had feature request New feature or request

Comments

@eatyourpeas
Copy link
Member

eatyourpeas commented Aug 23, 2024

RCPCH Project Board 22.8.24

There has been longstanding confusion about the fact that centile lines between WHO and UK90 references do not line up. This is particularly seen in the head circumference chart where the overlap is of the order of 2 centiles.

Decision was therefore made to implement de-emphasised vertical lines at the join between references, with a tooltip to explain the discrepancy to users.

Vertical lines (grey / deemphasised, no prop) for all measurement methods at:

  • aged 42 weeks
  • aged 4 years
  • vertical labels associated with each line explaining non-disjunction or retain existing tool tips.
@eatyourpeas eatyourpeas added feature request New feature or request consistency Not strictly a bug, but an implementation could be made clearer discussion A discussion that has been had or needs to be had labels Aug 23, 2024
@eatyourpeas eatyourpeas self-assigned this Aug 23, 2024
@statist7
Copy link

Don't forget to include the disjunctions at 2 years for WHO height and BMI, due to the change from length to height.

@eatyourpeas
Copy link
Member Author

Just to be clear - we always did have tool tips that appeared when users hovered over the breaks between references explaining the discrepancy and I have left those in. These extra lines are just clearer signposting.
image
especially for head circumference which initiated this issue.
image
If @statist7 agrees (and everyone else) I will merge this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Not strictly a bug, but an implementation could be made clearer discussion A discussion that has been had or needs to be had feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants