-
Notifications
You must be signed in to change notification settings - Fork 391
WIP: Default run.py
with env variables
#673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I won't make any changes to the |
I really like the idea of this, it would simplify a lot of Docker based setups. I would like to suggest retaining support for custom version: "3.9"
services:
miner:
image: rdavidoff/twitch-channel-points-miner-v2
stdin_open: true
tty: true
environment:
- TERM=xterm-256color
volumes:
- ./analytics:/usr/src/app/analytics
- ./cookies:/usr/src/app/cookies
- ./logs:/usr/src/app/logs
- ./run.py:/usr/src/app/run.py:ro
ports:
- "5000:5000"
entrypoint: python docker-run.py I would also like to suggest supporting all configuration options. Looking through the
I think that's it but feel free to check again. |
Description
Copied the
example.py
intorun.py
and made it read variables from the env. Also, createdenv.md
explaining usage.This isn't a change directly linked to an issue. I wanted to use this without having to copy / paste the
example.py
and work in the working directory of the container. Environmental variables work really nicely.Now for anyone with Docker running, you just need to spin up a container with the miner image, and set some environment variables. It's a lot simpler.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've built the image, and ran using environmental variables only.
Checklist: