Development/documentation #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MFransen69
requested changes
Jan 13, 2025
| else | ||
| Client->>Server: Connect to port (default 443) | ||
|
|
||
| Note over Client,Server: TLS handshake |
There was a problem hiding this comment.
As TLS in principle is not connected to the WebSocket protocol itself I think we either remove that part or otherwise make that clear in the title and add some text to explain that?
There was a problem hiding this comment.
It denotes an alternative path as the diagram illustrates: WebSocket is on top of existing infrastructure, regular or TLS tunnelled (see https://www.rfc-editor.org/rfc/rfc6455.html#page-4 and https://www.rfc-editor.org/rfc/rfc6455.html#page-11). The diagram does not explain TLS in detail. Solid line delineated (blocks) text is to be interpreted as comment. Actually, the 'initial part of' the protocol starts with sending an HTTP upgrade request.
MFransen69
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.